I have done rotational molding. It works, but the surface finish is usually "underhood automotive grade" - somewhat rough, with some grinding work on the outside.
Then there is the issue of the cap, and how to attach it.
To see a well designed plastic tank & cap, look at the tank on a Buell Blast
Why not just use a tank from Ghetto Bike James?
He makes a nice metal tank.